Changeset 42401

Timestamp:

12/15/2017 08:30:50 AM (7 years ago)

Author:

pento

Message:

Canonical URLs: Redirect to the correct URL when the post date changes.

When a post slug is changed, we store a copy of the old slug, so that we can redirect visitors visiting the old URL to the new URL.

In the same way, this stores a copy of the old date, when the post date changes, so we can redirect visitors to the new URL.

Props nickmomrik.
Fixes #15397 for trunk.

Location:

trunk

Files:

• src/wp-includes/default-filters.php (modified) (1 diff)
• src/wp-includes/post.php (modified) (1 diff)
• src/wp-includes/query.php (modified) (3 diffs)
• tests/phpunit/tests/rewrite/oldDateRedirect.php (added)

trunk/src/wp-includes/default-filters.php

@@ -355 +355 @@
 add_action( 'attachment_updated', 'wp_check_for_changed_slugs', 12, 3 );
 
+
+
+
+
 // Nonce check for Post Previews
 add_action( 'init', '_show_post_preview' );

trunk/src/wp-includes/post.php

@@ -5709 +5709 @@
 
 /**
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
  * Retrieve the private post SQL based on capability.
  *

trunk/src/wp-includes/query.php

@@ -846 +846 @@
  *
  * @since 2.1.0
- *
- * @global wpdb $wpdb WordPress database abstraction object.
  */
 function wp_old_slug_redirect() {
     if ( is_404() && '' !== get_query_var( 'name' ) ) {
-        global $wpdb;
-
         // Guess the current post_type based on the query vars.
         if ( get_query_var( 'post_type' ) ) {
@@ -876 +872 @@
         }
 
-        $query = $wpdb->prepare( "SELECT post_id FROM $wpdb->postmeta, $wpdb->posts WHERE ID = post_id AND post_type = %s AND meta_key = '_wp_old_slug' AND meta_value = %s", $post_type, get_query_var( 'name' ) );
-
-        // if year, monthnum, or day have been specified, make our query more precise
-        // just in case there are multiple identical _wp_old_slug values
-        if ( get_query_var( 'year' ) ) {
-            $query .= $wpdb->prepare( ' AND YEAR(post_date) = %d', get_query_var( 'year' ) );
+        $id = _find_post_by_old_slug( $post_type );
+
+        if ( ! $id ) {
+            $id = _find_post_by_old_date( $post_type );
         }
-        if ( get_query_var( 'monthnum' ) ) {
-            $query .= $wpdb->prepare( ' AND MONTH(post_date) = %d', get_query_var( 'monthnum' ) );
-        }
-        if ( get_query_var( 'day' ) ) {
-            $query .= $wpdb->prepare( ' AND DAYOFMONTH(post_date) = %d', get_query_var( 'day' ) );
-        }
-
-        $id = (int) $wpdb->get_var( $query );
+
+        /**
+         * Filters the old slug redirect post ID.
+         *
+         * @since 4.9.2
+         *
+         * @param string $id The redirect post ID.
+         */
+        $id = apply_filters( 'old_slug_redirect_post_id', $id );
 
         if ( ! $id ) {
@@ -923 +918 @@
 
 /**
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
  * Set up global post data.
  *