Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Super Cache: If Jetpack is installed, allow the site owner to choose between Jetpack mobile detection, wp_is_mobile(), or legacy system. #33034

Open
1 task
donnchawp opened this issue Sep 13, 2023 · 0 comments
Open
1 task

Super Cache: If Jetpack is installed, allow the site owner to choose between Jetpack mobile detection, wp_is_mobile(), or legacy system. #33034

donnchawp opened this issue Sep 13, 2023 · 0 comments
Assignees
@donnchawp
Labels
[Plugin] Super Cache A fast caching plugin for WordPress. [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Milestone
super-cache/1.12.5

Comments

@donnchawp
Copy link
Contributor

Super Cache uses a very old way of detecting if a visitor is using a mobile client. The WordPress wp_is_mobile() function didn't exist when mobile support was added.

If Jetpack is installed, we should allow the site owner to choose Jetpack mobile detection or wp_is_mobile() when they enable mobile support. Jetpack mobile detection should be the default.

Look like this:

  • Mobile device support.

  • Jetpack Mobile detection

  • WordPress Mobile detection

  • Legacy WP Super Cache detection

The three methods would be radio boxes so only one system can be chosen.
@donnchawp donnchawp self-assigned this Sep 13, 2023
@donnchawp donnchawp changed the title Super Cache: If Jetpack is installed then enable Jetpack mobile detection if mobile support is enabled, else use wp_is_mobile() Sep 13, 2023
@donnchawp donnchawp changed the title Super Cache: If Jetpack is installed then enable Jetpack mobile detection if mobile support is enabled, else use wp_is_mobile(), or legacy system Sep 13, 2023
@donnchawp donnchawp added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Pri] Low [Plugin] Super Cache A fast caching plugin for WordPress. labels Sep 13, 2023
@donnchawp donnchawp added this to the super-cache/1.12.0 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Super Cache A fast caching plugin for WordPress. [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
1 participant
@donnchawp