Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Show more descriptive error on failure to download compressed files #33433

Open
Agepeuve opened this issue Oct 2, 2023 · 4 comments
Open

Feature Request: Show more descriptive error on failure to download compressed files #33433

Agepeuve opened this issue Oct 2, 2023 · 4 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] WPCOM API [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@Agepeuve
Copy link

Agepeuve commented Oct 2, 2023 •
edited by jeherve
Loading

Impacted plugin

Jetpack

What

Add a descriptive error if a compressed file fails to download for security reasons

How

If you upload a .zip file that contains an executable file (.bat for example) to a site, you will not be able to download it. A generic error will be displayed: "This site can't be reached".

Screenshot of the error: 5Ppwje.png

If you remove the .bat file, you will be able to download the .zip file correctly. Ideally, the user should see a warning when uploading this type of file, or the error page displayed could be more specific.
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Oct 2, 2023
@jeherve
Copy link
Member

jeherve commented Oct 2, 2023

Could you walk me the steps you followed to get to that error, including the URL of the page where you started the process?

Thank you!
@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! General and removed [Type] Feature Request labels Oct 2, 2023
@Agepeuve
Copy link
Author

Agepeuve commented Oct 4, 2023 •
edited by jeherve
Loading

Hey! This feature was first requested here: pd4QKa-Sx-p2

I haven't had a chance to speak to the user who reported the problem, but if I'm not mistaken, this is what they did:

1.- Upload a file containing a .bat file to the Media Library. You won't get any errors.
2.- Link the file to a post or page.
3.- Try to download the file and you will see the error.

I've checked and they've already deleted the original file, but I'm pretty sure they'll have no problem sharing it with us if you think that might help.
@jeherve jeherve added [Feature] WPCOM API [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Pri] Low and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! General labels Oct 4, 2023
@jamiepalatnik
Copy link

A user reported the same issue in 8478524-zd-a8c
@github-actions GitHub Actions
Copy link
Contributor

Support References

This comment is automatically generated. Please do not edit it.

  • 8478524-zen
@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] WPCOM API [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
3 participants
@jeherve @jamiepalatnik @Agepeuve