Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paid Content Block - Caching Issue for showing correct content on buttons #34948

Open
janmckell opened this issue Jan 10, 2024 · 4 comments
Open
Labels
[Block] Paid Content aka Premium Content Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". Earn Earn features [Feature] Paid Content aka Premium Content. Controlling specific content for paying site visitors. [Platform] Simple [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack [Status] Stale Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@janmckell
Copy link

Impacted plugin

Jetpack

Quick summary

A user had added 3 different payment plans and payment buttons, but all the buttons were redirecting to the first payment plan only.

If they reload the page, however. then all the buttons link to the correct payment plan.

Tested this further and it looks like a page caching issue with the blocks.

See this screen record:
https://github.com/Automattic/jetpack/assets/84089207/9d8cdb1b-fa7d-4333-b785-bb932bb59c1d

As a workaround, an HE suggested that they create 3 different pages and have payment buttons linked on each of the pages. Then, on the Store page, create 3 columns with buttons that'd link to those pages.

Steps to reproduce

Add multiple payment plans
Add each plan to a payment button on a page
Save the page
Test or preview the page
All buttons link to the same payment plan, until the page is reloaded and then each button links to its own (and the correct) payment plan.

A clear and concise description of what you expected to happen.

Each button should link to the correct payment plan, without the need to refresh the page first.

What actually happened

No response

Impact

One

Available workarounds?

Yes, difficult to implement

Platform (Simple and/or Atomic)

Simple

Logs or notes

No response

@janmckell janmckell added [Type] Bug When a feature is broken and / or not performing as intended [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Needs triage Ticket needs to be triaged [Feature] Paid Content aka Premium Content. Controlling specific content for paying site visitors. labels Jan 10, 2024
@janmckell
Copy link
Author

Reported here:
7474952-zd-a8c

Copy link
Contributor

Support References

This comment is automatically generated. Please do not edit it.

  • 7474952-zen
@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Jan 10, 2024
@github-actions github-actions bot added the [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack label Jan 11, 2024
@rickmgithub rickmgithub added Triaged and removed Needs triage Ticket needs to be triaged [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack labels Jan 11, 2024
@github-actions github-actions bot added the [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack label Jan 11, 2024
@jeherve jeherve added Earn Earn features [Block] Paid Content aka Premium Content labels Jan 11, 2024
@anomiex
Copy link
Contributor

anomiex commented Jan 11, 2024

A user had added 3 different payment plans and payment buttons, but all the buttons were redirecting to the first payment plan only.

If they reload the page, however. then all the buttons link to the correct payment plan.

I see slightly different behavior when I tried reproducing this: whichever button is clicked first (after loading or reloading the page) shows the plan(s) associated with that button as expected. Closing the modal and clicking any other buttons re-shows the modal without updating the contents.

Copy link
Contributor

This issue has been marked as stale. This happened because:

  • It has been inactive for the past 6 months.
  • It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Type] Feature Request`, `[Type] Enhancement`, `[Type] Janitorial`, `Good For Community`, `[Type] Good First Bug`, etc.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Paid Content aka Premium Content Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". Earn Earn features [Feature] Paid Content aka Premium Content. Controlling specific content for paying site visitors. [Platform] Simple [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Status] Priority Review Triggered The guild in charge of triage has been notified of this issue in Slack [Status] Stale Triaged [Type] Bug When a feature is broken and / or not performing as intended
5 participants