Super Cache: use win_is_writable function instead of repeating that code in is_writeable_ACLSafe

[donnchawp]

Impacted plugin

Super Cache

Quick summary

On Windows, the filesystem security model is complicated and not supported entirely by PHP. To correctly know if a directory is writable, we must create a temporary file there.

In WordPress 2.8.0, the win_is_writable function was introduced to do this.

The function is_writeable_ACLSafe in Super Cache predates the win_is_writable() function, and both were taken from comments in the is_writable PHP manual page.

As win_is_writable contains the same code, we should use that instead.

Steps to reproduce

No issue, just want to use the WordPress native function instead.

A clear and concise description of what you expected to happen.

N/A

What actually happened

N/A

Impact

One

Available workarounds?

There is no user impact

Platform (Simple and/or Atomic)

Self-hosted

Logs or notes

No response

[github-actions]

This issue has been marked as stale. This happened because:

• It has been inactive for the past 6 months.
• It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Type] Feature Request`, `[Type] Enhancement`, `[Type] Janitorial`, `Good For Community`, `[Type] Good First Bug`, etc.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.