Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Countdown block timezone is unclear and inconsistent #38285

Open
anomiex opened this issue Jul 10, 2024 · 3 comments
Open

Event Countdown block timezone is unclear and inconsistent #38285

anomiex opened this issue Jul 10, 2024 · 3 comments
Labels
[Block] Event Countdown [Platform] Atomic [Platform] Simple [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@anomiex
Copy link
Contributor

anomiex commented Jul 10, 2024

Impacted plugin

Jetpack

Quick summary

I tried to add an instance of the Event Countdown block to a post. It was very unclear what timezone it was interpreting the input in, and as far as I can tell it was wrong.

Steps to reproduce

  1. Have your timezone set to America/New York. Not sure if this is your browser, or your blog, or what.
  2. Add an Event Countdown block.
  3. Try to set an event for a specific UTC time a few months in the future, across the next DST change.
  4. Publish, then calculate the time of the target event based on what's shown in the block.

A clear and concise description of what you expected to happen.

Ideally, a clear indication in the picker and in the button exactly what timezone is being used. Even better if I can select the timezone.

What actually happened

No timezone is indicated in the picker or in the button. After entering a time and dismissing the picker, the button shows a time 1 hour off from what was entered.

It appears that the picker interprets the entered time based on the current UTC offset, not the offset that will be in effect on the selected date. The button displays the time using the offset that will be in effect on the selected date, and the block itself displays the countdown to what the button displays.

Impact

All

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple, Atomic, Self-hosted

Logs or notes

No response

@anomiex anomiex added [Type] Bug When a feature is broken and / or not performing as intended [Pri] Normal [Block] Event Countdown labels Jul 10, 2024
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Platform] Atomic [Platform] Simple labels Jul 10, 2024
@anomiex
Copy link
Contributor Author

anomiex commented Jul 10, 2024

@Automattic/lego This looks like something you worked on recently?

@Aurorum
Copy link
Contributor

Aurorum commented Jul 10, 2024

If no choice is offered, I still remain extremely keen to see this block use the site timezone by default (see #14289 for context - that’s also the default behaviour of the Milestone Widget).

@arthur791004
Copy link
Contributor

We just migrated the existing block from ETK to Jetpack. We'll take a look this issue later.

@mrfoxtalbot mrfoxtalbot added Triaged Needs triage Ticket needs to be triaged and removed Needs triage Ticket needs to be triaged labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Event Countdown [Platform] Atomic [Platform] Simple [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended
4 participants