Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WooCommerce Analytics: remove module from the Jetpack plugin and stop requiring the package. #38295

Open
Tracked by #35511
jeherve opened this issue Jul 11, 2024 · 4 comments

Comments

@jeherve
Copy link
Member

jeherve commented Jul 11, 2024

Once the feature is included in the WooCommerce plugin, it can safely be removed from the Jetpack plugin.

@puntope When do you think we could reasonably stop loading the package in the Jetpack plugin? We release a new version of the Jetpack plugin monthly. When can we assume a version of the WooCommerce plugin will have been out and available long enough so most site owners have updated and we can remove the feature from Jetpack?


Epic: #35511

@puntope
Copy link
Contributor

puntope commented Jul 11, 2024

Hey @jeherve thanks for the ping.

That depends on your compatibility policy. I created a PR which is already merged to avoid initialize the plugin if it's loaded in WooCommerce. I assume that it will be be released in Jetpack on 6th August as Jetpack team confirmed to me recently.

However, it can be the case that users are using the new version of Jetpack but an old version of WooCommerce (without the package loading in Woo) in those cases Jetpaxck is still initializing the package.

In our plugins (like GLA) we offer L-2 policy. But not sure about Jetpack. Let's assume it is also L-2 policy. Then let's assume also that the feature is released on WooCommerce v9.4 (I can confirm this soon). Then you should keep the package in Jetpack minimum until WooCommerce v9.6 and delete it in v9.7.

Does this make sense?

@jeherve
Copy link
Member Author

jeherve commented Jul 11, 2024

let's assume also that the feature is released on WooCommerce v9.4 (I can confirm this soon). Then you should keep the package in Jetpack minimum until WooCommerce v9.6 and delete it in v9.7.

Yep, this is what I was looking for, thank you! Do you already know when those versions of Woo will be released, approximately?

@puntope
Copy link
Contributor

puntope commented Jul 11, 2024

Yep, this is what I was looking for, thank you! Do you already know when those versions of Woo will be released, approximately?

The versions were just examples. We need to discuss how we want to tackle the tracking permissions (GDPR etc) Once this is clarified I can commit to a Woo version and also I can ping JP team if that's ok.

@jeherve
Copy link
Member Author

jeherve commented Jul 11, 2024

Sounds good, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment