Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items that link to PDFs fail to load in reader view #1616

Open
blackketter opened this issue Jan 12, 2020 · 3 comments
Open

Items that link to PDFs fail to load in reader view #1616

blackketter opened this issue Jan 12, 2020 · 3 comments

Comments

@blackketter
Copy link

If an item points to a PDF file rather than a web page it fails to load in reader view. It wold be great if a pdf is detected it is just loaded and displayed rather than failing.

This is related to #1542, which prevents PDF items from being available at all if auto reader view is on.

@vincode-io
Copy link
Member

Do you have a feed you can share that has this behavior? I've never seen a blog that has its posts displayed as PDF's before.

@blackketter
Copy link
Author

Sure. The Hacker News feed does this pretty regularly:

http://news.ycombinator.com/rss

There's an item in there from today:

<item>
<title>Patch Critical Cryptographic Vulnerability in Microsoft Windows [pdf]</title>
<link>https://media.defense.gov/2020/Jan/14/2002234275/-1/-1/0/CSA-WINDOWS-10-CRYPT-LIB-20190114.PDF</link>
<pubDate>Tue, 14 Jan 2020 18:16:39 +0000</pubDate>
<comments>https://news.ycombinator.com/item?id=22047573</comments>
<description>
<![CDATA[<a href="https://news.ycombinator.com/item?id=22047573">Comments</a>]]>
</description>
</item>
@blackketter
Copy link
Author

I see in the new release that the PDFs fail to load but now show the original RSS data. That's good! You can tap on the title to open the PDF in the web view. Also good!
There's a cosmetic bug where on the first visit to the page the reader view button continues to animate after the failure. (It stops animating after viewing the PDF and returning).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants