Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dock menu of unread items (like NNW had) #83

Open
Diggory opened this issue Jun 1, 2017 · 5 comments
Open

Add Dock menu of unread items (like NNW had) #83

Diggory opened this issue Jun 1, 2017 · 5 comments

Comments

@Diggory
Copy link

Diggory commented Jun 1, 2017

I love the hierarchical dock menu in NetNewsWire (so much so that I'm still using v3.x)

Please implement this in Evergreen.
Thanks.

@brentsimmons brentsimmons added this to the 1.0 alpha milestone Nov 13, 2017
@brentsimmons brentsimmons modified the milestones: 1.0 Alpha, 2.0 Alpha Dec 14, 2017
@brentsimmons brentsimmons removed this from the 2.0 Alpha milestone Aug 24, 2018
@Wevah
Copy link
Member

Wevah commented Oct 5, 2019

Should selecting an article in the Dock menu open the article's URL (like NNW 3.x), or select the article in NNW?

@Diggory
Copy link
Author

Diggory commented Oct 5, 2019

My personal preference is URL - but perhaps left as an option (as in NNW 3.x)

Screenshot 2019-10-05 at 11 58 35

@Wevah
Copy link
Member

Wevah commented Oct 5, 2019

"Open links in: NetNewsWire" still opens the URL (in-app insted of in-browser) vs. selecting the feed in the app, as far as I can tell. Since NNW 5 doesn't have an in-app browser yet, I'll just have it open in the default browser (which is easier than selecting the articles in the timeline, anyway).

@Wevah
Copy link
Member

Wevah commented Oct 5, 2019

I've got this mostly working, but popping the menu is kind of slow since it has to build the entire menu when it's popped up. I may look at building the menu before it's popped, asynchronously.

Using NSMenuDelegate + menuNeedsUpdate() was fruitless, as it seems that for the Dock menu, menuNeedsUpdate() is called for the submenus right away instead of just before they're opened.

@brentsimmons
Copy link
Collaborator

We’re unlikely to do this — it’s a big performance hit when there are lots of unread items, which is a pretty typical thing for a lot of people.

We were able to do it in NetNewsWire of Yore because we kept all unread articles in memory all the time. We use memory better these days! But at the cost of making this feature do-able.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants