Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support allow-forms in SandBox component #48942

Open
dhasilva opened this issue Mar 8, 2023 · 1 comment
Open

Support allow-forms in SandBox component #48942

dhasilva opened this issue Mar 8, 2023 · 1 comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
WordPress Components

Comments

@dhasilva
Copy link

dhasilva commented Mar 8, 2023

What problem does this address?

Automattic/jetpack#28375
We have a problem with the VideoPress block where a video can have a rating of R-17, where the user needs to input their birthdate for age verification:
2023-03-08_17-31-12

The VideoPress block renders the VideoPress player inside an iframe via the SandBox component here, but the SandBox component does not allow for form submission, so the block is stuck like that when using the editor.

What is your proposed solution?

I believe that adding allow-forms here would solve that, or maybe a prop to allow that when needed.
@dhasilva dhasilva mentioned this issue Mar 8, 2023
Open
@talldan talldan added [Package] Block editor /packages/block-editor [Package] Components /packages/components [Type] Enhancement A suggestion for improvement. and removed [Package] Block editor /packages/block-editor labels Mar 9, 2023
@talldan
Copy link
Contributor

talldan commented Mar 9, 2023

It might be good to make it a prop, so that it's implementers can configure what they're happy to allow in a Sandbox.
@mirka mirka added this to Inbox (needs triage) 📬 in WordPress Components via automation Mar 13, 2023
@dhasilva dhasilva mentioned this issue Apr 13, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
2 participants
@talldan @dhasilva