Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimension tools: Add icons for block spacing and min. height #62618

Open
jasmussen opened this issue Jun 17, 2024 · 5 comments
Open

Dimension tools: Add icons for block spacing and min. height #62618

jasmussen opened this issue Jun 17, 2024 · 5 comments
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

The current dimensions panel has icons for padding and margin stepped controls, but not for block spacing and min-height controls. This causes misalignment of the controls, making it less scannable. Additionally, in case of width-based controls, or axial gap configuration, an icon denoting the orientation can help anchor the feature.

Here's a design proposal that adds icons for block spacing and min-height, shown before and after:

before and after

Beyond lining up vertically, this also unifies the controls so that in the future, axial controls (row-gap or column-gap vs. just gap) could be added to the block spacing control. To that end, here are potential icon designs that would work for axial gap configurations:

dimensions-icons

Figma.

@jasmussen jasmussen added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Jun 17, 2024
@jarekmorawski
Copy link

Good idea! I think this is a meaningful improvement, but only when paired with more granular settings for controlling the vertical and horizontal gap separately. I can already think of a use case: in WooCommerce, you may want to add a small gap to the product collection so the rows have more breathing room while the grid's density remains the same. Currently, I'd do that by adding a top padding to the product card block, but this setting would work much better.

We'd make Block Spacing work similarly to Padding and Margin, meaning that we'd surface granular settings when the user clicks the icon next to the label. Here's a quick sketch.

image

In the future, this consistency would enable us to easily overhaul the whole Dimensions panel and clean up all UI controls at once: from Margin to Block Spacing to Width.

@richtabor
Copy link
Member

I'm not sure if it's the right icon, but I do like that it makes the sliders more uniform and understandable.

@akasunil
Copy link
Member

For min height icon, could we use something like this?

originally proposed in #55734 for full height toggle.

@mateuswetah
Copy link
Contributor

mateuswetah commented Jun 28, 2024

Not a big fan of the proposed height icon too... it reminds me to much an "I". I like the bar with arrows... or maybe we could have something close to this, using a bit of the style of the side padding and margin?

image

@jameskoster
Copy link
Contributor

A small detail, but it would be good to use the new DropdownMenu component here:

Screenshot 2024-07-01 at 11 02 58

Since this is not a multi-select option we should avoid the checkbox icon and use DropdownMenuRadioItem. An additional consideration is that radio menu items do not support an icon. So if the icon is critical, we may need to consider a different UI (segmented control?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
6 participants