Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template column width: adjust center column pages. #134

Closed
jasmussen opened this issue Jun 18, 2024 · 4 comments
Closed

Template column width: adjust center column pages. #134

jasmussen opened this issue Jun 18, 2024 · 4 comments
Labels
[Component] Theme Templates, patterns, CSS

Comments

@jasmussen
Copy link

The current Page template has a max-width of 680px, center aligned:

Image

The grid of thumbnails has a max-width of 1160:

Image

Individual theme pages are also 1160:

Image

On pages like Commercial themes, the flow gets disrupted a little bit because both types of layout are present:

Image

The mix of these two causes a bit of a tipping layout. Suggestion: unify on 1160px across, but with a left aligned column for content, that's not quite full-wide. Here's an example from the original directory design:

Image

In that particular image, the left aligned column inside is 680px:

Image

This matches similar designs for Documentation:

Image

Whether it's 680 or something closer to the left-column width of theme permalinks, or even the 800px from the Learn mockups, the important part is that it's a left aligned column inside a container that's 1160px. Learn example:

Image

@ndiego
Copy link
Member

ndiego commented Jun 18, 2024

I think this approach works. It would look like this. The Group just needs to be aligned wide and the justification set to left. The screenshot just shows the top of the page, but the bottom text would be the same.

image
@ryelle
Copy link
Collaborator

ryelle commented Jun 18, 2024

I can make that change, but I'm having trouble following all the screenshots above— is that the only change required here?

@ryelle ryelle added [Component] Content Bugs or issues related to the page content [Component] Theme Templates, patterns, CSS and removed [Component] Content Bugs or issues related to the page content labels Jun 18, 2024
@ryelle
Copy link
Collaborator

ryelle commented Jun 18, 2024

Oh, does this need to happen for all pages?

@jasmussen
Copy link
Author

Oh, does this need to happen for all pages?

I think that would be ideal. I don't think we have many pages where we have the 680px column plainly centered. It's always assumed to have either whitespace, or a sidebar (not present on the theme directory) in the area on the right.

@ryelle ryelle closed this as completed in b450b5f Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS
3 participants