Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the possiblity and method to replace GLOG with spdlog #2267

Open
1 of 2 tasks
PragmaTwice opened this issue Apr 22, 2024 · 5 comments
Open
1 of 2 tasks

Investigate the possiblity and method to replace GLOG with spdlog #2267

PragmaTwice opened this issue Apr 22, 2024 · 5 comments
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers

Comments

@PragmaTwice
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

spdlog (https://github.com/gabime/spdlog) is a modern logging library based on fmt library (or std::format).

It's better to use spdlog instead of glog because we extensively utilize the fmt library.

Note: we need to specify SPDLOG_FMT_EXTERNAL since we need to keep there's only one fmt library in our deps.

Solution

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@PragmaTwice PragmaTwice added enhancement type enhancement help wanted Good for newcomers good first issue Good for newcomers labels Apr 22, 2024
@YaroslavStepanchuk
Copy link

@PragmaTwice Good idea. However, we use this function from the glog library https://github.com/apache/kvrocks/blob/unstable/src/cli/signal_util.h#L54.

I was looking for a way to get rid of it because in the glog-0.7.0 it's no more public.

N.B. I tried to use the libunwind but failed to add it to the project. However, it's a different story :)

@133tosakarin
Copy link

hello, I'm a beginer, Can I choose this issue ?

@git-hulk
Copy link
Member

@133tosakarin Perhaps you can try #2266 first.

@letian-jiang
Copy link

@git-hulk @PragmaTwice Could you assign this one to me?

BTW, is there any expected performance improvement after replacing GLOG with spdlog?

@PragmaTwice
Copy link
Member Author

BTW, is there any expected performance improvement after replacing GLOG with spdlog?

I think it's good if there's no noticeable performance degradation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement good first issue Good for newcomers help wanted Good for newcomers
5 participants