-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the default namepace name changable #2293
Comments
I have learned kvrocks for some time. I have the will to implement that (or have a try).
|
Also another big issue is to be compatible to old version: users can use new version of kvrocks with their old data, and they want these old data can work well. |
@PragmaTwice I'm not quite sure why we want to make it changeable. If for the space overhead consideration, it shouldn't take much more than the shorter one since the rocksdb has internal compression for the common prefix. |
Because I believe the default namespace should have the same status as other namespaces. |
Just curious why it should be changable? Is there any reason for that?
It's a good reason but I think we have too many legacy user and perhaps this means maintaining two parts of code? |
If there is a good solution, we can avoid maintenance difficulties and correct this problem. (But TBH, design errors in the early stage will lead to unbearable costs, and everyone should understand this truth.) Perhaps it's time for us to reconsider the authentication and permission management in kvrocks. |
We can achieve this by supporting the switch namespace API? The initial design didn't expect the admin to change data of other namespaces except to maintain the namespace/token pair itself. And I do agree the default namespace is very special, but it's to align with the Redis authentication way. |
Search before asking
Motivation
It should be changable, as other namespaces.
Solution
No response
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: