-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fatal because --exclude does not exclude for version request with --all #412
Comments
Thanks for the report, @kkmuffme ! Feel free to submit a pull request, if you'd like. Here is some guidance on our pull request best practices. |
Hey @danielbachhuber @kkmuffme, I couldn't replicate this issue. I tried it on both a live site with WP-CLI 2.10.0 and in a Behat test. Everything seems to be working fine. It updated some plugins and skipped the one specified in the A live site![]() Behat test
Result![]() |
I also tried with themes but could not reproduce the error.
Then:
|
I think that I understand the problem. It feels like the plugin/theme in question is throwing a fatal error at the moment of the update. While inspecting the code, I was able to determine that the plugins/themes in the What probably is causing this issue is that the plugin/theme is loading when the @kkmuffme have you tried to run that command appending at the end of that |
Bug Report
Describe the current, buggy behavior
wp theme update --all --exclude=foo
wp plugin update --all --exclude=foo
ParseThemeNameInput::check_optional_args_and_all
(same for plugin) will try to get update info viathemes_api
for all themes/updates even the excluded ones.This is a problem if the theme/plugin is excluded because it will make the updater crash e.g. if it hooks onto filter
themes_api_args
in thethemes_api
function, which leads to nothing getting updated(since the add_filter function has a fatal error)
Describe what you would expect as the correct outcome
Don't check excluded plugins/themes for newer version/updates.
Let us know what environment you are running this on
WP CLI 2.10.0
Provide a possible solution
Change
check_optional_args_and_all
to skip excluded in $all case?The text was updated successfully, but these errors were encountered: