WordPress.org

Resolved Biranit
(@biranit)

4 years, 9 months ago

Hi,

Since upgrading to PHP7.3, our debug/error log is full of the following notice:

“PHP message: PHP Notice: compact(): Undefined variable: tcp in /***/wp-content/db.php on line 648”

Can you please suggest how this should be fixed?

Thanks,

Bira

Viewing 5 replies - 1 through 5 (of 5 total)

George Stephanis
(@georgestephanis)

4 years, 8 months ago

Hrm, looks like it’s been hitting a number of frameworks. Laravel was whammied by it here a bit ago: https://github.com/laravel/framework/issues/26936

The relevant lines in hyperdb are 648

https://plugins.trac.wordpress.org/browser/hyperdb/trunk/db.php?rev=1785108#L648

and the ominously numbered 666

https://plugins.trac.wordpress.org/browser/hyperdb/trunk/db.php?rev=1785108#L666

It looks like the version of this we’re running on wpcom has been updated so that line is doing server_state instead of tcp which seems to track with what the surrounding code is implementing.

I’m going to try to do a cleanup of this tomorrow and get a diff posted to plugins trac for review and merge to the plugin.

Thanks for saying something! 🙂

Plugin Contributor Peter Westwood
(@westi)

4 years, 8 months ago

@biranit please can you test the updated version in /trunk/ and verify everything works for you and then I will release an updated version 1.6 with this and the other pending fix.

Thread Starter Biranit
(@biranit)

4 years, 8 months ago

@westi I can confirm this fixes the error notice, and everything else seems to work fine. Thank you 🙂

Plugin Contributor Peter Westwood
(@westi)

4 years, 8 months ago

I’ve tagged v1.6 which resolves this.

justinmaurerdotdev
(@360zen)

4 years, 4 months ago

Not sure if this is a good place to mention this, but I just reported another PHP 7.3 compatibility issue on Trac. https://plugins.trac.wordpress.org/ticket/2860#ticket

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘PHP 7.3 compatibility’ is closed to new replies.