Skip to:
Content

bbPress.org

Opened 16 months ago

Closed 6 weeks ago

Last modified 6 weeks ago

#3544 closed defect (bug) (fixed)

View RSS feeds return the all-topic feed if the view doesn't exist

Reported by: dd32's profile dd32 Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 2.6.10 Priority: high
Severity: normal Version: 2.1
Component: API - Feeds Keywords: has-patch commit
Cc:

Description

If a request such as ​https://example.org/view/dd32-is-awesome/feed/ is requested, bbPress will process the request and output a valid feed.

Unfortunately, on most sites, this bbPress view simply doesn't exist.

The attached PR resolves this similar to how the non-feed query handles validating if the view exists: ​https://github.com/bbpress/bbPress/blob/394ae31c059228e866240076db2dc2ca2ddc8a7c/src/includes/core/template-functions.php#L650-L658

Change History (5)

This ticket was mentioned in ​PR #10 on ​bbpress/bbPress by ​@dd32.
16 months ago #1

  • Keywords has-patch added

Trac: ​https://bbpress.trac.wordpress.org/ticket/3544

#2 @dd32
16 months ago

I patched this on the WordPress.org forums like so: ​https://meta.trac.wordpress.org/changeset/12529

#3 @johnjamesjacoby
16 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 2.6.10
  • Owner set to johnjamesjacoby
  • Priority changed from normal to high
  • Status changed from new to assigned
  • Version set to 2.1

#4 @johnjamesjacoby
6 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 7264:

Views: do not trap RSS feeds for unregistered views

This change adds a check inside of bbp_request_feed_trap() that only allows bbp_display_topics_feed_rss2() to happen if query-arguments exist for the slug of the view that is being requested.

Without this check in place, the view unintentionally includes all topics, because no additional arguments are passed into bbp_has_topics().

Fixes #3544.

Props dd32.

In branches/2.6, for 2.6.10.

Note: See TracTickets for help on using tickets.