Network Users alternate row highlighting does not work properly

[nickmomrik]

If you browse to wp-admin/network/users.php and mark a user (that user row must have the 'alternate' class already) as spam, the row's background will not be light red as expected. It will still be the alternate color and then the next row will now be the alternate color as well.

I've attached two possible solutions.

[scribu]

I thought there was a guideline somewhere for never using !important in any WP css files.

[scribu]

trac just keeps getting funkier and funkier.

[wpmuguru]

A third way to address this would be to make the .site-spammed more specific by adding .wp-list-table .site-spammed to the CSS.

[wpmuguru]

use CSS to highlight the status

[westi]

With SCRIPT_DEBUG enabled I don't see this issue.

So I just think we may need to re-compress some CSS.

[westi]

Ok. It looks like the underlying bug that really needs fixing is this.

The CSS files are output in different orders with SCRIPT_DEBUG enabled/disabled - which is why the CSS for this is being overridden by other CSS.

That shouldn't happen because it makes testing of patches hard and gives different behvaiour between live/dev

[westi]

In progress hacking

[westi]

I see no harm in the css changes proposed to make them more specific - in fact they are probably a good idea.

The attached patch works towards removing the hacky 'colours' style loading code and move towards using the normal en-queuing so that it works correctly with or without SCRIPT_DEBUG and the colour css gets loaded via load-styles too.

[wpmuguru]

16827.3.diff + fix for #faa => #faafaa

[wpmuguru]

[16902] expanded #faa to #faafaa. #faa is the shortform of #ffaaaa. 16827.4.diff combines 16827.3.diff with a fix for the #faa.

[nacin]

Nice catch. We should move back to #faa rather than #ffaaaa for standards purposes.

[wpmuguru]

16827.4.diff with #faa

[wpmuguru]

This still does not have the 3.2 milestone on it. Is there are reason it's being left off the list?

[westi]

Replying to wpmuguru:

This still does not have the 3.2 milestone on it. Is there are reason it's being left off the list?

Nope. I thought I already set that when I started working on it :(

[westi]

For 3.2 I think we should just fix the CSS
The Script Loaded diversion I will raise as a separate ticket for 3.3

[westi]

In [18086]:

Make the css for the row status highlighting more specific so that it works regardless of the ordering of the CSS loading. Fixes #16827 props wpmuguru.