Twenty Fifteen: Bottom border on `a` elements looks odd when the link content is an image

[jblz]

It's particularly unnerving when the image has transparency because you can see the border line through the middle of the image.

[jblz]

How it looks with the rule applied

[jblz]

How it looks without the rule applied

[jblz]

Rule is here:
https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentyfifteen/style.css?rev=29892#L1700

[rachelbaker]

While border-bottom allows for fancier styles accounting for the different types of content (videos, iframes, images, etc) that can be wrapped in an anchor element it looks like text-decoration: underline is the only cross-browser supported non-jQuery solution here.

[iamtakashi]

Will the patch above cause any issue?

[iandstewart]

Patch works for me.

[iandstewart]

In 29927:

Twenty Fifteen: make sure we don't see borders through transparent linked images.

Props iamtakashi, fixes #29963.

[jblz]

Thanks, all.

[iamtakashi]

I was testing with some third party widgets and I've seen some issues because of 29963.diff.

The sicons should be next to each other.

We should narrow down the scope of 29963.diff to just the main content where we add borders to links.

[iamtakashi]

Narrow down the scope of removing border from linked images.

[iandstewart]

Fixed with r30269.