-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Analytics: initialize via MU-WPCOM plugin #37622
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Boost plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well on my WoA site.
I would approve, but I notice all the wpcomsh auto-formatting changes and it seems like they don't need to be there? They don't look like they'd cause any harm as it's mainly whitespace fixes, but to be safe I wouldn't want to approve without testing all the touched files. Is the intention to keep them in?
bd41150
to
8fc15ac
Compare
@coder-karen thanks for taking a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks!
Proposed changes:
Other information:
Jetpack product discussion
https://github.com/Automattic/vulcan/issues/312
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
add/google-analytics-to-mu-wpcom
) for "WordPress.com Features".htdocs/wp-config.php
:define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true );
delete/jetpack-module-google-analytics
.