Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Analytics: initialize via MU-WPCOM plugin #37622

Merged
merged 17 commits into from
Jul 12, 2024

Conversation

sergeymitr
Copy link
Contributor

@sergeymitr sergeymitr commented May 29, 2024

Proposed changes:

  • Initialize Google Analytics package via MU-WPCOM plugin.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/vulcan/issues/312

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  1. Create/reuse a WoA site. Use Jetpack Beta to checkout this PR's branch (add/google-analytics-to-mu-wpcom) for "WordPress.com Features".
  2. To activate the MU-WPCOM plugin, go to "Settings -> Hosting Configuration", use SFTP or SSH credentials to add the constant to htdocs/wp-config.php: define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true );
  3. In Calypso, go to "Tools -> Marketing -> Traffic" and activate Google Analytics. Enter a measurement ID (e.g. "G-12345"), click "Save".
  4. Check the frontend, confirm the tracking code shows up with the correct measurement ID.
  5. Deactivate Google Analytics, confirm the tracking code disappears.
  6. Use Jetpack Beta to switch Jetpack to the branch delete/jetpack-module-google-analytics.
  7. Refresh the "Tools -> Marketing -> Traffic" page, confirm the GA card is still there, still deactivated/folded.
  8. Repeat steps 3-5, confirm the results are the same.
Copy link
Contributor

github-actions bot commented May 29, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Boost plugin:

  • Next scheduled release: August 6, 2024.
  • Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Mu Wpcom plugin:

  • Next scheduled release: August 6, 2024.
  • Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Wpcomsh plugin:

  • Next scheduled release: August 6, 2024.
  • Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

github-actions bot commented May 29, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/google-analytics-to-mu-wpcom branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/google-analytics-to-mu-wpcom
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2
@github-actions github-actions bot added [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Wpcomsh [Tests] Includes Tests E2E Tests labels Jun 24, 2024
@sergeymitr sergeymitr added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Jul 9, 2024
Copy link
Contributor

@coder-karen coder-karen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well on my WoA site.

I would approve, but I notice all the wpcomsh auto-formatting changes and it seems like they don't need to be there? They don't look like they'd cause any harm as it's mainly whitespace fixes, but to be safe I wouldn't want to approve without testing all the touched files. Is the intention to keep them in?

@coder-karen coder-karen added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jul 11, 2024
@sergeymitr sergeymitr force-pushed the add/google-analytics-to-mu-wpcom branch from bd41150 to 8fc15ac Compare July 11, 2024 19:44
@sergeymitr
Copy link
Contributor Author

sergeymitr commented Jul 11, 2024

@coder-karen thanks for taking a look!
Yeah, those auto-formatted files are confusing.
I managed to revert them so we could deal with it later.

@sergeymitr sergeymitr added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jul 11, 2024
Copy link
Contributor

@coder-karen coder-karen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@sergeymitr sergeymitr merged commit 3fc8c3c into trunk Jul 12, 2024
55 checks passed
@sergeymitr sergeymitr deleted the add/google-analytics-to-mu-wpcom branch July 12, 2024 18:46
@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants