Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component for authenticated experiments to ExPlat #37999

Merged
merged 8 commits into from
Jul 11, 2024

Conversation

IanRamosC
Copy link
Contributor

@IanRamosC IanRamosC commented Jun 23, 2024

See related issue

Proposed changes:

  • This PR implement another set of hooks and components to be used specifically for running experiments for authenticated users.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Yes. It adds a way to run A/B experiments specifically with authenticated users.

Testing instructions:

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@IanRamosC IanRamosC self-assigned this Jun 24, 2024
@IanRamosC IanRamosC force-pushed the add/explat-authenticated-component branch from 4d50684 to 4e34a27 Compare June 28, 2024 00:00
Copy link
Contributor

@CodeyGuyDylan CodeyGuyDylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and it tested well!

@IanRamosC IanRamosC merged commit a96f994 into trunk Jul 11, 2024
53 checks passed
@IanRamosC IanRamosC deleted the add/explat-authenticated-component branch July 11, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants