Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Instant Search Dependency Updates #38133

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

matticbot
Copy link
Contributor

@matticbot matticbot commented Jul 1, 2024

This PR contains the following updates:

Package Type Update Change
@testing-library/preact devDependencies patch 3.2.3 -> 3.2.4
preact (source) dependencies minor 10.12.1 -> 10.22.1
preact (source) dependencies patch 10.22.0 -> 10.22.1

Release Notes

testing-library/preact-testing-library (@​testing-library/preact)

v3.2.4

Compare Source

Bug Fixes
preactjs/preact (preact)

v10.22.1

Compare Source

Fixes
Types
Maintenance
Performance

v10.22.0

Compare Source

Features
Types
Maintenance
Fixes

v10.21.0

Compare Source

Features

Fixes

Types

Maintenance

v10.20.2

Compare Source

Fixes

Types

Maintenance

v10.20.1

Compare Source

Fixes

v10.20.0

Compare Source

Features
  • Add isMemo to compact to allow compatibility with react-is dependant libraries (#​4302, thanks @​ziongh)
Fixes

v10.19.7

Compare Source

Types

Fixes

v10.19.6

Compare Source

tl;dr: This release contains bug fixes for incorrect ordering of unkeyed children.

Fixes

Full Changelog: preactjs/preact@10.19.5...10.19.6

v10.19.5

Compare Source

Fixes

Types

v10.19.4

Compare Source

Fixes

Types

Maintenance

v10.19.3

Compare Source

Bug Fixes

Maintenance

v10.19.2

Compare Source

Fixes

Maintenance

v10.19.1

Compare Source

Fixes

Types

v10.19.0

Compare Source

Features

Fixes

Performance

Types

v10.18.2

Compare Source

Types
Fixes
Improvements
Maintenance

v10.18.1

Compare Source

Fixes

v10.18.0

Compare Source

Features
Types
Fixes
Maintenance

v10.17.1

Compare Source

Fixes

Types

Maintenance

v10.17.0

Compare Source

Features

Types

Fixes

Maintenance

v10.16.0

Compare Source

Improved child diffing

We have noticed a few scenario's where children would get unmounted and remounted eagerly due to some offset bugs in our child-diffing, with skew-based diffing we plan to address those. This is already part of v11 and has been introduced there by @​andrewiggins. This has now been backported to Preact X so we can benefit from the consistency improvements here as well.

Defer setting refs

We used to set refs as part of the children, synchronously this caused several issues when a ref would go down a level, i.e. the following example

const App = () => {
  return phase === 1 ? <div ref={x}><p>Foo</p></div> : <div><div ref={x}><p>Foo</p></div>
}

In this example when we go from phase 1 to phase 2 we would mount a new ref but only after we bubble back up diffing clean up the outer ref making the ref reset to null.

Fixes

Types

v10.15.1

Compare Source

Fixes
Types

v10.15.0

Compare Source

Revert

fixes

Types

v10.14.1

Compare Source

Fixes

v10.14.0

Compare Source

Features

Fixes

Types

Maintenance

v10.13.2

Compare Source

Performance

Maintenance

v10.13.1

Compare Source

Bug Fixes

Performance

Maintenance

v10.13.0

Compare Source

Features

Bug Fixes

Types


Configuration

📅 Schedule: Branch creation - "before 3am on the first day of the month" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@matticbot matticbot added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial Instant Search Search labels Jul 1, 2024
@github-actions github-actions bot added [Package] Ad aka WordAds [Package] Search Contains core Search functionality for Jetpack and Search plugins labels Jul 1, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the renovate/instant-search-dependency-updates branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack renovate/instant-search-dependency-updates
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin renovate/instant-search-dependency-updates
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2
@jeherve jeherve removed the Search label Jul 1, 2024
@anomiex
Copy link
Contributor

anomiex commented Jul 2, 2024

Renovate is configured to add "jetpack-search" as a reviewer on these (along with the Search and Instant Search labels), but that team seems to no longer exist in GitHub. @Automattic/jetpack-data-team I think you "own" Search now? Should I update that team assignment to you? Or I could remove the special config and let these be handled like any other Renovate update.

Besides preact and @testing-library/preact, the special config is being applied to the cache, progress-event, q-flat, qss, strip, and uuid npm packages.

@matticbot matticbot force-pushed the renovate/instant-search-dependency-updates branch from 3247757 to 99a6fa8 Compare July 2, 2024 18:10
@gibrown gibrown assigned gibrown and kangzj and unassigned gibrown Jul 3, 2024
@gibrown
Copy link
Member

gibrown commented Jul 3, 2024

@kangzj I added you to this. I think we should probably have Red be the team for reviewing these sort of dependency updates.

@kangzj kangzj merged commit 7e7d826 into trunk Jul 7, 2024
73 checks passed
@kangzj kangzj deleted the renovate/instant-search-dependency-updates branch July 7, 2024 22:05
@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Instant Search [Package] Ad aka WordAds [Package] Search Contains core Search functionality for Jetpack and Search plugins [Type] Janitorial
6 participants