-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin: Redirect Jetpack Admin Pages to Specific Sections #38148
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
projects/plugins/jetpack/_inc/lib/admin-pages/class.jetpack-admin-page.php
Outdated
Show resolved
Hide resolved
@@ -75,6 +75,16 @@ public function __construct() { | |||
* @param Jetpack $jetpack object. | |||
*/ | |||
public function on_jetpack_loaded( $jetpack ) { | |||
// phpcs:ignore WordPress.Security.NonceVerification.Recommended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the ignore twice in this function? We can disable/enable it for this code block, but please specify why as a short comment:
phpcs:ignore WordPress.Security.NonceVerification.Recommended -- a GET request that doesn't change anything on the server side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the ignore twice in this function?
phpcs complains if we don't add it twice.
projects/plugins/jetpack/_inc/lib/admin-pages/class.jetpack-admin-page.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good
I tested different cases and they all worked as expected for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
When linking to a specific page with a hash (#), (ie. https://wp.org/wp-admin/admin.php?page=jetpack#/newsletter) the hash gets stripped by the login redirect. As a result, these pages can’t be linked from documentation or support resources. This change ensures there's a way to link users to specific pages.
Proposed changes:
•Query Parameter Check: Verify if the page query parameter is set and starts with jetpack/.
•Section Extraction: Extract the specific section from the page parameter.
•Safe Redirect: Perform a safe redirect to the Jetpack admin page, anchoring the user to the specified section.
Other information:
Jetpack product discussion
p1719856268371719-slack-C052XEUUBL4
Does this pull request change what data or activity we track or use?
Testing instructions: