-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI Breve: Update highlight logic to use RichText #38189
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
@@ -1,7 +1,7 @@ | |||
import phrases from '../features/complex-words/phrases'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file could be renamed to .ts
for consistency (could not comment on the file as there is no change there)
const currentContent = | ||
typeof block.attributes.content === 'string' | ||
? create( { html: block.attributes.content } ) | ||
: create( block.attributes.content ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocks don't have to set their text content on attributes.content
. Tables do not and the complex words are not detected there.
For the readability calculation we are using getBlockContent
to get the block's HTML and then stripping the tags out. For that case it works, but here we'll need some more thought 🤔
// We need to wait for the highlights to be applied before we can attach events | ||
setTimeout( () => { | ||
feature.events(); | ||
}, 2000 ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value is too high. Is there a way we can listen to the highlights being applied? Or, failing that, we need to make it much lower.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well for paragraphs. For follow-ups we need to make it work with other blocks.
Fixes problems related with Breve usage since it was not native integrated with Gutenberg.
Proposed changes:
highlights
to useregisterFormatType
Breve
store.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Breve
.Complex Words
.