Untangling Cleanup: Clean up wpcom_is_nav_redesign_enabled() flag

[xavier-lc]

Related to: https://github.com/Automattic/dotcom-forge/issues/7927

Proposed changes:

• As we've launched untangling & nav redesign, the wpcom_is_nav_redesign_enabled function name is not relevant anymore and can be confusing for future developers.

This goes alongside this wpcom PR: D154312-code

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Apply this patch on your sandbox
• On a site using the classic admin interface style, set the wpcom_classic_tour_completed option to '0':
  • On your sandbox, run wpsh and then update_blog_option( SITE_ID, 'wpcom_classic_tour_completed', '0' );
• Go to /wp-admin/?admin-interface-changed=true
• Check that you see the tour dialog:

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/rename-wpcom_is_nav_redesign_enabled branch.

  • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack update/rename-wpcom_is_nav_redesign_enabled
  

  bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/rename-wpcom_is_nav_redesign_enabled
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for August 6, 2024 (scheduled code freeze on August 5, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Mu Wpcom plugin:

• Next scheduled release: August 6, 2024.
• Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

---

Wpcomsh plugin:

• Next scheduled release: August 6, 2024.
• Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[fushar]

Thanks for this! Some comments:

1. One of the reasons we used wpcom_is_nav_redesign_enabled() (and therefore the massive function_exists checks) in wpcomsh, is so that we could quickly release/revert the feature in wpcomsh, without having to rely on Jetpack release cycle. Now that it's released, we don't need to rely on wpcomsh anymore. That's the reason why I proposed in the issue to just simply use get_option( 'wpcom_admin_interface' ) === 'wp-admin' as it's literally what it is.
2. If we still want to use functions, what I suggest is:
   • Put the function in another feature in mu-wpcom. E.g.: admin-interface/admin-interface.php
   • Use it and remove all the function_exists checks.
   • See this example Hide wpcom items if is_agency_managed_site #37993, where we added a similar is_agency_managed_site() function.
3. We should do similar thing in wpcomsh and not rely on the feature-plugins/nav-redesign.php file anymore, as that would defeat the purpose of the refactor.

What do you think?

[fushar]

Can we now rename the PR 😄

[xavier-lc]

Can we now rename the PR 😄

@fushar haha right, done!

[fushar]

Triple-checked the changes, and smoke-tested on a WoA dev test site and everything works as usual. Nice 👍

[fushar]

Merging this now to unblock things because we have another Untangling iteration this week!

[xavier-lc]

@fushar thanks for merging this!