Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Client: Filter suggestions starting with llama artifacts #38208

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

dhasilva
Copy link
Contributor

@dhasilva dhasilva commented Jul 4, 2024

ref p1720130920711329/1718723268.245799-slack-C050S8KG677

Proposed changes:

  • Removes the starting <|start_header_id|>assistant<|end_header_id|>\n text from llama suggestions

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Sandbox the public API and simulate a llama3 call on Breve (ref p1720134386106669/1720134295.868489-slack-C054LN8RNVA)
  • Without this PR applied, check that changes turn into the llama artifact string
  • With this PR applied, check that the requests work as expected
@dhasilva dhasilva added [Status] Needs Team Review [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [JS Package] AI Client labels Jul 4, 2024
@dhasilva dhasilva requested a review from a team July 4, 2024 23:07
@dhasilva dhasilva self-assigned this Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/jetpack-ai-client-remove-llama-artifact branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/jetpack-ai-client-remove-llama-artifact
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2
@github-actions github-actions bot added the RNA label Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for August 6, 2024 (scheduled code freeze on August 5, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

CGastrell
CGastrell previously approved these changes Jul 5, 2024
Copy link
Contributor

@CGastrell CGastrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It's an improvement and it doesn't affect any other functionality. That said, Llama seems to be adding extra content, so I guess this is fine and we need to continue refining the prompts or the content filters

:shipit:

image

Seems to pile up on previous requests as well:
image

@dhasilva dhasilva enabled auto-merge (squash) July 8, 2024 20:41
Copy link
Contributor

@CGastrell CGastrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM x 2 :shipit:

@dhasilva dhasilva merged commit 1da44f6 into trunk Jul 8, 2024
54 checks passed
@dhasilva dhasilva deleted the update/jetpack-ai-client-remove-llama-artifact branch July 8, 2024 20:54
@github-actions github-actions bot added this to the jetpack/13.7 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JS Package] AI Client [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ RNA
2 participants