Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MU WPCOM: Port jetpack-global-styles from ETK #38209

Merged
merged 12 commits into from
Jul 9, 2024

Conversation

okmttdhr
Copy link
Member

@okmttdhr okmttdhr commented Jul 5, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/8057

Proposed changes:

This PR ports jetpack-global-styles from ETK, as discussed in pbxlJb-5Xo-p2.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Patch this PR
  • Activate one of themes in https://wordpress.com/themes/all/filter/editor-fonts (e.g., Leven)
  • Go to page or post editor
    • Change font selection
    • Publish fonts
      Screenshot 2024-07-05 at 17 17 06
    • Observe fonts are applied on frontend
  • Go to Appearance > Customize
    • Click "Fonts" section
    • Observe the links. ⚠️ Note that the first link is displayed only if your "Your homepage displays" is set to a static page.
      Screenshot 2024-07-05 at 17 17 48
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Copy link
Contributor

github-actions bot commented Jul 5, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the mu-wpcom/jetpack-global-styles branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack mu-wpcom/jetpack-global-styles
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin mu-wpcom/jetpack-global-styles
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2
@okmttdhr okmttdhr self-assigned this Jul 5, 2024
@okmttdhr okmttdhr marked this pull request as ready for review July 5, 2024 07:02
@okmttdhr okmttdhr marked this pull request as draft July 5, 2024 07:02
@okmttdhr okmttdhr marked this pull request as ready for review July 5, 2024 08:21
@okmttdhr okmttdhr requested a review from a team July 5, 2024 08:22
fushar
fushar previously approved these changes Jul 9, 2024
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:

✅ Go to page or post editor, Change font selection, Publish fonts, Observe fonts are applied on frontend.
✅ Click "Fonts" section Observe the links.


Tested on:

✅ Simple
✅ Atomic with ETK activated
✅ Atomic with ETK deactivated

@okmttdhr okmttdhr requested a review from a team July 9, 2024 08:32
Copy link
Contributor

@fushar fushar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested and still works nicely 👍

@okmttdhr okmttdhr merged commit 8b4991d into trunk Jul 9, 2024
72 checks passed
@okmttdhr okmttdhr deleted the mu-wpcom/jetpack-global-styles branch July 9, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment