Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MU WPCOM: Port tags-education feature from ETK #38210

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

taipeicoder
Copy link
Contributor

@taipeicoder taipeicoder commented Jul 5, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/8037.

Proposed changes:

Port the tags-education feature from ETK, which adds the link Build your audience with tags↗ to the Tags section.

Screenshot 2024-07-05 at 9 57 05 PM

Note

I did not port the use of localeUrl() since it was more complicated than I thought. As a result, the link URL will always link to the English version. This seems like an acceptible compromise since the support page already has links to other languages in it header.

Screenshot 2024-07-05 at 10 12 55 PM

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Head to the Post Editor.
  • Open the Settings panel, and expand the Tags section.
  • Ensure that the link "Build your audience with tags↗" is available.
  • Ensure that the event jetpack_mu_wpcom_tags_education_link_click triggers on link click.
  • In Atomic sites, ensure that the ETK plugin is disabled.
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the mu-wpcom/tags-education branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack mu-wpcom/tags-education
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin mu-wpcom/tags-education
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@taipeicoder taipeicoder force-pushed the mu-wpcom/tags-education branch 2 times, most recently from e794b3e to 35acfff Compare July 5, 2024 06:28
@taipeicoder taipeicoder self-assigned this Jul 5, 2024
@taipeicoder taipeicoder marked this pull request as ready for review July 5, 2024 14:10
@taipeicoder taipeicoder requested a review from a team July 5, 2024 14:10
@taipeicoder taipeicoder added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Jul 5, 2024
Copy link
Contributor

@arthur791004 arthur791004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected!

@taipeicoder taipeicoder merged commit e4b409b into trunk Jul 8, 2024
77 of 79 checks passed
@taipeicoder taipeicoder deleted the mu-wpcom/tags-education branch July 8, 2024 05:24
@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment