Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost: Add tracks events #38211

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Boost: Add tracks events #38211

merged 3 commits into from
Jul 8, 2024

Conversation

haqadn
Copy link
Contributor

@haqadn haqadn commented Jul 5, 2024

Fixes Automattic/boost-cloud#493

Proposed changes:

  • Added identifiers for contextual triggers
  • Added tracks event for performance history CTA

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

No

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Click upgrade CTA on performance history panel
  • See if jetpack_boost_performance_history_upgrade_cta_click got recorded.
  • Click the contextual triggers under, Critical CSS, Image CDN, Image Guide.
  • Make sure jetpack_boost_upsell_cta_from_settings_page_in_plugin events are recorded with an identifier prop.
@haqadn haqadn requested a review from a team July 5, 2024 05:52
@haqadn haqadn self-assigned this Jul 5, 2024
@github-actions github-actions bot added the [Plugin] Boost A feature to speed up the site and improve performance. label Jul 5, 2024
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Boost plugin:

  • Next scheduled release: August 6, 2024.
  • Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Member

@pyronaur pyronaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haqadn haqadn merged commit f392190 into trunk Jul 8, 2024
61 checks passed
@haqadn haqadn deleted the add/tracks-events branch July 8, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Boost A feature to speed up the site and improve performance.
2 participants