Social: Add recommendation steps for the V1 plan #38219

gmjuhasz · 2024-07-05T12:00:49Z

Fixes https://github.com/Automattic/jetpack-reach/issues/439

Proposed changes:

Changed the advanced plan recommendation steps and cards to be used with the V1 plan

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/jetpack-reach/issues/439

Does this pull request change what data or activity we track or use?

Testing instructions:

Create a new JN site, or delete jetpack options on your local site to reset the onboarding flows. jetpack docker wp option delete jetpack_options. You'll have to reconnect Jetpack after this.
Ensure you do not have the social plan, then buy it for the site. You should get redirected to the Social onboarding flow. There you should see 4 steps, the first one is a welcome, then SIG introduction, then a general monitor and accelerator pages.

CleanShot.2024-07-05.at.14.03.53.png.mp4

github-actions · 2024-07-05T12:01:42Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/social-v1-recommendation-steps branch.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/social-v1-recommendation-steps

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2024-07-05T12:01:43Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen daily.
WoA releases happen weekly.
Releases to self-hosted sites happen monthly. The next release is scheduled for August 6, 2024 (scheduled code freeze on August 5, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

manzoorwanijk

Works fine

pablinos

Looks like a good first step. The suggestion from Marketing was to have a recommendation for all sites, promoting the free version. Perhaps we could repurpose the Basic recommendation for that? It would be fine to do that as a separate change of course.

pablinos · 2024-07-08T05:56:25Z

projects/plugins/jetpack/_inc/client/recommendations/constants.js

@@ -41,12 +41,12 @@ export const RECOMMENDATION_WIZARD_STEP = {
 	WELCOME__SEARCH: 'welcome__search',
 	WELCOME__SCAN: 'welcome__scan',
 	WELCOME__SOCIAL_BASIC: 'welcome__social_basic',
-	WELCOME__SOCIAL_ADVANCED: 'welcome__social_advanced',
+	WELCOME__SOCIAL_V1: 'welcome__social_v1',


Do we need to keep the Advanced flow for now in case people are activating the legacy plans? If not, then do we need to keep the Basic recommendations?

Is that still sellable? Even if it is, I'm not sure we should support that with the onboarding as it's deprecated anyway.
cc @spsiddarthan

~~We can get rid of the old plans here~~

We can let those be for now, Jetpack Manage hasn't deprecated the old plans yet.

pablinos · 2024-07-08T05:58:58Z

projects/plugins/jetpack/_inc/client/recommendations/feature-utils.js

 			return {
 				question: __( 'Welcome to Jetpack Social!', 'jetpack' ),
 				description: __(
-					"With your new advanced plan you unlocked unlimited sharing, access to upload photos and videos with your posts, and usage of Social Image Generator.<br/><br/>Let's start with connecting your social media accounts, if you haven't already.",
+					"With your new Social plan you unlocked priority support, access to upload photos and videos with your posts, and usage of Social Image Generator.<br/><br/>Let's start with connecting your social media accounts, if you haven't already.",
 					'jetpack'
 				),
 				ctaText: __( 'Manage Social Media Connections', 'jetpack' ),


We should update this link too. I suppose we could bring up the connections modal on this page, but it might be better to send them to the Sharing settings instead.

Fixed in 67bb287

gmjuhasz · 2024-07-08T09:12:54Z

Because of p1720428043465199-slack-C02JJ910CNL, I made it so on the welcome pages we open the sharing section in a new tab, to not mess up the onboarding flow

spsiddarthan

When I only have Jetpack Social active and buy a plan, it takes me to this blank page. Can you replicate that behaviour? You can test it on a new JN site.

Also, we can leave the old plans be since Jetpack Manage hasn't deprecated the old plans yet. We can add a task to the backlog to clean that up.

gmjuhasz · 2024-07-09T09:51:37Z

When I only have Jetpack Social active and buy a plan, it takes me to this blank page. Can you replicate that behaviour? You can test it on a new JN site.

After my investigation that's an issue on trunk and with Calypso. p1720514740440389-slack-C02JJ910CNL

Fixed in https://github.com/Automattic/jetpack-reach/issues/446

spsiddarthan

This works well!

gmjuhasz added 2 commits July 5, 2024 13:58

Update the advanced plan recommendations for the v1 plan

fd1d278

changelog

cc23a20

gmjuhasz added the [Status] Needs Team Review label Jul 5, 2024

gmjuhasz requested a review from a team July 5, 2024 12:00

gmjuhasz self-assigned this Jul 5, 2024

github-actions bot added [JS Package] Licensing [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress Admin Page React-powered dashboard under the Jetpack menu RNA labels Jul 5, 2024

Fixup versions

f49268d

gmjuhasz marked this pull request as ready for review July 5, 2024 12:26

manzoorwanijk previously approved these changes Jul 8, 2024

View reviewed changes

pablinos reviewed Jul 8, 2024

View reviewed changes

gmjuhasz changed the title ~~Social: Add recommendation steps for the V1 pla~~ Jul 8, 2024

Use the sharing page for connections with the UI v1

67bb287

gmjuhasz dismissed manzoorwanijk’s stale review via 67bb287 July 8, 2024 09:11

Merge branch 'trunk' into update/social-v1-recommendation-steps

0984aa5

spsiddarthan reviewed Jul 9, 2024

View reviewed changes

Merge branch 'trunk' into update/social-v1-recommendation-steps

79f0b13

gmjuhasz requested review from a team, pablinos and spsiddarthan July 9, 2024 09:54

spsiddarthan approved these changes Jul 12, 2024

View reviewed changes

gmjuhasz merged commit 9c947ac into trunk Jul 15, 2024
70 checks passed

gmjuhasz deleted the update/social-v1-recommendation-steps branch July 15, 2024 07:51

github-actions bot removed [Status] In Progress [Status] Needs Team Review labels Jul 15, 2024

github-actions bot added this to the jetpack/13.7 milestone Jul 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Social: Add recommendation steps for the V1 plan #38219

Social: Add recommendation steps for the V1 plan #38219

gmjuhasz commented Jul 5, 2024 •

edited

Loading

github-actions bot commented Jul 5, 2024 •

edited

Loading

github-actions bot commented Jul 5, 2024

manzoorwanijk left a comment

pablinos left a comment

pablinos Jul 8, 2024

gmjuhasz Jul 8, 2024

spsiddarthan Jul 9, 2024 •

edited

Loading

pablinos Jul 8, 2024

gmjuhasz Jul 8, 2024

gmjuhasz commented Jul 8, 2024

spsiddarthan left a comment •

edited

Loading

gmjuhasz commented Jul 9, 2024 •

edited

Loading

spsiddarthan left a comment

Social: Add recommendation steps for the V1 plan #38219

Social: Add recommendation steps for the V1 plan #38219

Conversation

gmjuhasz commented Jul 5, 2024 • edited Loading

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Jul 5, 2024 • edited Loading

github-actions bot commented Jul 5, 2024

manzoorwanijk left a comment

Choose a reason for hiding this comment

pablinos left a comment

Choose a reason for hiding this comment

pablinos Jul 8, 2024

Choose a reason for hiding this comment

gmjuhasz Jul 8, 2024

Choose a reason for hiding this comment

spsiddarthan Jul 9, 2024 • edited Loading

Choose a reason for hiding this comment

pablinos Jul 8, 2024

Choose a reason for hiding this comment

gmjuhasz Jul 8, 2024

Choose a reason for hiding this comment

gmjuhasz commented Jul 8, 2024

spsiddarthan left a comment • edited Loading

Choose a reason for hiding this comment

gmjuhasz commented Jul 9, 2024 • edited Loading

spsiddarthan left a comment

Choose a reason for hiding this comment

gmjuhasz commented Jul 5, 2024 •

edited

Loading

github-actions bot commented Jul 5, 2024 •

edited

Loading

spsiddarthan Jul 9, 2024 •

edited

Loading

spsiddarthan left a comment •

edited

Loading

gmjuhasz commented Jul 9, 2024 •

edited

Loading