Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social: Change Manage connections button to a link with connections #38220

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

gmjuhasz
Copy link
Contributor

@gmjuhasz gmjuhasz commented Jul 5, 2024

Fixes https://github.com/Automattic/jetpack-reach/issues/442

Proposed changes:

  • Eder suggested that we only use buttons for main actions, so the manage connection button is changed back to link if the number of connections is greater than 0.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/jetpack-reach/issues/442

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Go to the editor, and validate the states.
  • You can mimic having no connections by returning [] in with getConnections in projects/js-packages/publicize-components/src/social-store/selectors/connection-data.js
  • The link and button should have the same functionality which is opening the connections modal
No connections Having connections
CleanShot 2024-07-05 at 14 52 13 png CleanShot 2024-07-05 at 14 52 49 png
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the change/social-manage-connection-link branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack change/social-manage-connection-link
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Copy link
Member

@manzoorwanijk manzoorwanijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well

@gmjuhasz gmjuhasz merged commit bcb5e62 into trunk Jul 8, 2024
58 checks passed
@gmjuhasz gmjuhasz deleted the change/social-manage-connection-link branch July 8, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment