-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social Logos: Add post-build tests #38224
base: trunk
Are you sure you want to change the base?
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think #37799 probably already cleaned up most of the possibilities for errors by making the various scripts actually fail if something goes wrong.
/** | ||
* Checks that each SVG file in the source folder has an equivalent file in the build folder. | ||
*/ | ||
function checkSVGBuilds() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find myself wondering what series of events would make this fail.
/** | ||
* Verifies the SVG optimization is working. | ||
*/ | ||
function verifySVGOptimization() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit skeptical about this one too. Is there some failure case this is targeting?
*/ | ||
function verifyOtherBuildFiles() { | ||
// Here lie all expected built files (without the build folder prefix). | ||
const expectedBuildFiles = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this would be fairly easy to get out of date, if there ever are any new files we'll probably forget to add them here.
This moves the existing test out of the build script and adds a few more rudimentary post-build tests. This will help prevent silent errors from resulting in a broken build (e.g. regressions discovered/fixed in #37799).
As written, it runs as part of
composer build-production
. Feel free to adapt as desired.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Run
composer build-production
and verify it works as expected.