Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: fix Stats Learn More link when site is disconnected #38225

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

IanRamosC
Copy link
Contributor

@IanRamosC IanRamosC commented Jul 6, 2024

See related issue for more context

Proposed changes:

  • This PR fixes the Learn More link specifically for Stats when the user has never been connected. It sends the user to the product interstitial instead of sending to a broken screen.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Spin up a JN site with Jetpack Beta pointing to this branch
  • Visit My Jetpack
  • Scroll down to the Stats section and click on "Learn more" without connecting to Jetpack
image * Confirm that you are redirected to `/wp-admin/admin.php?page=my-jetpack#/add-stats`
Copy link
Contributor

github-actions bot commented Jul 6, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/learn-more-url-for-disconnected-stats branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/learn-more-url-for-disconnected-stats
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2
Copy link
Contributor

github-actions bot commented Jul 6, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ��� Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@IanRamosC IanRamosC marked this pull request as ready for review July 8, 2024 13:35
Copy link
Contributor

@CodeyGuyDylan CodeyGuyDylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks a couple cards that are also have the needs_first_site_connection status. For example, when I click on the Akismet "Learn More" CTA, I am now taken to the Stats interstitial. Same for Creator and AI

incorrect-interstitial.mov
@IanRamosC
Copy link
Contributor Author

This breaks a couple cards that are also have the needs_first_site_connection status. For example, when I click on the Akismet "Learn More" CTA, I am now taken to the Stats interstitial. Same for Creator and AI

You're right, it was not the right code lol

CodeyGuyDylan
CodeyGuyDylan previously approved these changes Jul 9, 2024
Copy link
Contributor

@CodeyGuyDylan CodeyGuyDylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, thanks for the fix!

This label will be displayed when the status of the product is NEEDS_FIRST_SITE_CONNECTION.
@CodeyGuyDylan CodeyGuyDylan self-requested a review July 10, 2024 13:44
@IanRamosC IanRamosC merged commit 602fd04 into trunk Jul 10, 2024
70 checks passed
@IanRamosC IanRamosC deleted the fix/learn-more-url-for-disconnected-stats branch July 10, 2024 14:11
@IanRamosC IanRamosC self-assigned this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants