-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MU WPCOM: Port Whats New from ETK #38229
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
b9d1063
to
4d09351
Compare
4d09351
to
76323b8
Compare
} | ||
|
||
$whats_new_handle = 'wpcom-whats-new'; | ||
$version = gmdate( 'Ymd' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that the file will only cached per-day, and would require a new download each day?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I followed how the command palette does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left a question https://github.com/Automattic/jetpack/pull/38229/files#r1668254127.
Related to https://github.com/Automattic/dotcom-forge/issues/8032, https://github.com/Automattic/dotcom-forge/issues/8035
Proposed changes:
@automattic/whats-new
package. The package is still used by Calypso side as well. As a result, I made Introduce Whats New App wp-calypso#92470 to build the Whats New app to share the package instead of publishing it to npm.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
... > What's new