Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MU WPCOM: Port Whats New from ETK #38229

Merged
merged 3 commits into from
Jul 9, 2024
Merged

MU WPCOM: Port Whats New from ETK #38229

merged 3 commits into from
Jul 9, 2024

Conversation

arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Jul 8, 2024

Related to https://github.com/Automattic/dotcom-forge/issues/8032, https://github.com/Automattic/dotcom-forge/issues/8035

Proposed changes:

  • Migrate the Whats New feature from the ETK plugin to jetpack-mu-wpcom
  • The UI of the Whats New feature is controlled by the @automattic/whats-new package. The package is still used by Calypso side as well. As a result, I made Introduce Whats New App wp-calypso#92470 to build the Whats New app to share the package instead of publishing it to npm.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Apply Introduce Whats New App wp-calypso#92470 to your sandbox
  • Apply this change to your sandbox
  • Sandbox your site
  • Sandbox widgets.wp.com
  • Go to the Editor
  • Open the Whats New by ... > What's new
  • Make sure you can see the What's New modal
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the mu-wpcom/whats-new branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin mu-wpcom/whats-new
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jul 8, 2024
@arthur791004 arthur791004 self-assigned this Jul 8, 2024
@arthur791004 arthur791004 force-pushed the mu-wpcom/whats-new branch 2 times, most recently from b9d1063 to 4d09351 Compare July 8, 2024 06:57
@arthur791004 arthur791004 added [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jul 8, 2024
}

$whats_new_handle = 'wpcom-whats-new';
$version = gmdate( 'Ymd' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that the file will only cached per-day, and would require a new download each day?

Copy link
Contributor Author

@arthur791004 arthur791004 Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I followed how the command palette does.

Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arthur791004 arthur791004 enabled auto-merge (squash) July 9, 2024 03:00
@arthur791004 arthur791004 merged commit de0c901 into trunk Jul 9, 2024
54 checks passed
@arthur791004 arthur791004 deleted the mu-wpcom/whats-new branch July 9, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment