Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP.com menu: Bring back "Plugins > Scheduled Updates" to classic sites #38231

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Jul 8, 2024

Proposed changes:

The "Plugins > Scheduled Updates" menu was meant to be visible on sites with the default interface when it was first introduced, but we mistakenly added a "is classic interface" check in a follow-up that prevented the menu from being visible on such sites.

This PR restores the original behavior and ensures that the "Plugins > Scheduled Updates" menu is visible on sites with both the default and the classic interface.

Before After
Screenshot 2024-07-08 at 09 52 28 Screenshot 2024-07-08 at 09 51 06

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Apply these changes to a WP.com site using the auto-generated instructions from the comment below
  • On Simple sites:
    • Default (no changes): The Plugins menu doesn't have submenu
    • Classic (no changes): The Plugins menus has three submenus: Installed Plugins, Add New Plugin, and Marketplace
  • On Atomic sites:
    • Default: The "Plugins > Scheduled Updates" submenu is visible. Additionally, the previous submenus (Installed Plugins, and Add New Plugin) remain visible
    • Classic (no changes): The Plugins menus has four submenus: Installed Plugins, Add New Plugin, Marketplace, and Scheduled Updates
@mmtr mmtr self-assigned this Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/plugins-scheduled-updates-menu branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/plugins-scheduled-updates-menu
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@mmtr mmtr requested a review from a team July 8, 2024 07:42
Copy link
Contributor

@dsas dsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm 👍

@mmtr mmtr merged commit d1da4aa into trunk Jul 8, 2024
60 checks passed
@mmtr mmtr deleted the fix/plugins-scheduled-updates-menu branch July 8, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment