-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide My Mailboxes link on P2 sites #38232
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me, but I'm still seeing My Mailboxes
in wp-admin
with the provided testing instructions. Could be an issue with me or my sandbox though.
@nightnei, can you test to confirm?
EDIT: Nevermind Vova, I got my box working and tested successfully, we're good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got my sandbox to cooperate, and can now test this effectively.
LGTM 🚀 🚢
Related to https://github.com/Automattic/dotcom-forge/issues/8069
Proposed changes:
My Mailboxes
sidebar link on P2 sitesOther information:
This fixes a regression from #32992, where the
My Mailboxes
link was renamed fromInbox
. TheInbox
link was previously hidden, but the renaming made the function call for removing the link void.Jetpack product discussion
https://github.com/Automattic/dotcom-forge/issues/8069 by way of p58i-hxi-p2
Does this pull request change what data or activity we track or use?
No
Testing instructions:
examplep2.wordpress.com
)/wp-admin
on a P2 siteMy Mailboxes
link