-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin bar: update to match with Nav Redesign i3 #38233
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
78c0cfe
to
0a3df8e
Compare
0a3df8e
to
986f634
Compare
986f634
to
95d7f27
Compare
95d7f27
to
145132b
Compare
projects/packages/jetpack-mu-wpcom/src/features/wpcom-admin-bar/wpcom-admin-bar.php
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
145132b
to
624d63f
Compare
We had a discussion about this exact thing in the issue https://github.com/Automattic/dotcom-forge/issues/8144#issuecomment-2213263720; we're gonna hold off adding that on wp-admin admin bar (for now). |
@okmttdhr, I just rebased and loses your review; could you quickly help smoke-test it again and hit the approve button again 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a test on Atomic Classic
Related to:
Proposed changes:
This PR updates the admin bar for WordPress.com sites as follows:
I also took the opportunity to split the
wpcom-site-menu
feature (which is getting too large) into 3:wpcom-admin-bar
wpcom-admin-menu
wpcom-sidebar-notice
With this, the responsibility of each feature is clear and localized.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: