Social: Fix frontend media validation logic

[gmjuhasz]

Fixes https://github.com/Automattic/jpop-issues/issues/9123

This issues is that we are validating the featured image when the validation is not necessary, because the image won't get uploaded anywhere. The only edge case is Instagram

Proposed changes:

• Put back the logic removed in Social: Remove share as a social post toggle #37964, but with the difference of using attachedMedia.length instead of the removed shouldUploadAttachedMedia

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/jpop-issues/issues/9123

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

• Have at least a Facebook and Instagram connection on your site, and have auto-conversion off.
• Create a new post and add a featured image that is bigger than 10Mb. On trunk this scenario should result in both Instagram and Facebook being disabled, because of the media restrictions.
• With this change only Instagram should get disabled, but not Facebook, because we only validate the featured image for Instagram.
• Test with auto-conversion on, it should still work as before

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/social-frontent-validation branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack fix/social-frontent-validation
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

[spsiddarthan]

Thanks for working on this, Geri!

The code makes logical sense, but I found the following use-case to be an outlier.

• I connected Facebook and Instagram both.
• I attached a custom image with 10MB after purchasing the paid plan
• I had auto-conversion off, but only Instagram was disabled. It could very well be that the Facebook image maximum allowed size is bigger than that, but it appears to be 8MB. Shouldn't Facebook be disabled too?

Some additional things to test:

• Have auto-conversion turned off on simple sites, you can do that from Jetpack Social MC. Auto-conversion is enabled by default on simple sites, so shouldn't be a problem.
• Patch this diff on a simple site and see if your fix solves the issue there for the featured image. It should do that 99.99%, but would be good to test.

I also noticed that we should update the documentation here https://jetpack.com/support/jetpack-social/convert-images-for-sharing/#understanding-platform-specific-media-requirements with the new social networks and their specifications. I will do that.

[gmjuhasz]

@spsiddarthan thanks for noticing. I had this fixed locally yesterday but that commit didn't get pushed, sorry! 🤦 Downside of juggling 4 PRs I guess 😅
Fixed in a1802a2

[spsiddarthan]

Works well!