WooCommerce Analytics: Initialize the package only if is not loaded in WooCommerce Core

[puntope]

Fixes woocommerce/woocommerce#45210
PT: pcShBQ-1Vt-p2

Proposed changes:

• This PR initializes WooCommerce_Analytics package only if it was not loaded in WooCommerce core

To do that, we created a WC_ANALYTICS constant in the WooCommerce core version when we load the package.
When this constant is present Jetpack will not initialize WooCommerce_Analytics.

This is for maintaining compatibility as it might happen that JEtpack gets updated but WooCommerce does not and vice versa.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

PT: pcShBQ-1Vt-p2

Does this pull request change what data or activity we track or use?

Added ✅

Testing instructions:

• Connect Jetpack and install WooCommerce
• Go to the shop as guest (or not an admin), add a product and then go to the cart
• In the web source you will see <script>window._wca = window._wca || [];</script> script loaded
• add the constant: define( 'WC_ANALYTICS', true )
• Go to the shop as guest (or not an admin), add a product and then go to the cart
• In the web source you won't see <script>window._wca = window._wca || [];</script> script loaded

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the tweak/load-wc-analytics-core branch.

• To test on Simple, run the following command on your sandbox:

  bin/jetpack-downloader test jetpack tweak/load-wc-analytics-core
  

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

---

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

• WordPress.com Simple releases happen daily.
• WoA releases happen weekly.
• Releases to self-hosted sites happen monthly. The next release is scheduled for August 6, 2024 (scheduled code freeze on August 5, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

[fgiannar]

LGTM!
Not sure if we need the Needs Privacy Updates label here, since we are not tracking any new data, just conditionally tracking the same Woo related data we used to, when WC_ANALYTICS is not present.

[jenhooks]

@fgiannar - hi! And thanks for the privacy flag on this, @puntope. Can y'all do a quick check of the privacy section in this doc https://jetpack.com/support/privacy/woocommerce-analytics/#privacy and let me know if any verbiage needs to be added or changed? Sometimes, when a change is needed, it might just mean making the existing language a little more inclusive or wider-scoped.

[puntope]

Howdy @jenhooks thanks for being proactive on this.

Not sure if that needs to be changed but I can summarize what it changed so it can clarify if it should:

Now WooCommerce Analytics is activated in these scenarios:

User still uses an old version of WooCommerce or Jetpack that doesn't load the WooCommerce Analytics package via WooCommerce.

--> In this case, the package is still loaded as always using Jetpack

User uses a new version of Jetpack and WooCommerce and the package is loaded in WooCommerce

1.. woocommerce_analytics_allow_tracking filter is true (by default false) This requirement is coming from Beau. And is still discussed how we do allow this to be true. Maybe with an extra opt-in check or some integration with WP Consent API (notice this package tracks customer info not just store admin info as WC Tracks does)

2. Jetpack should be activated and also connected to Wordpress.com (this might change soon, is still being discussed but likely we just require Wordpress.com connection without Jetpack plugin activation needed)

For now, I wouldn't change anything yet. In the PT pcShBQ-1Vt-p2 we have a task for discussing with privacy team once everything is discussed.

BTW. This claim is not correct on the page you mention

The WooCommerce Analytics module is activated by default when both the Jetpack and WooCommerce plugins are activated

Jetpack should be activated and also connected to Wordpress.com if it is just activated it doesn't track.