-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack mu and wpcomsh - hide wpcom items for non wpcom site users, hide hosting card from non-admins (re-ship) #38241
Jetpack mu and wpcomsh - hide wpcom items for non wpcom site users, hide hosting card from non-admins (re-ship) #38241
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested a non-wp.com user and a WP.com user with less than admin privileges. Both scenarios worked as expected.
@@ -21,6 +21,9 @@ function wpcomsh_plugins_show_banner() { | |||
if ( ! empty( get_option( 'is_fully_managed_agency_site' ) ) ) { | |||
return; | |||
} | |||
if ( function_exists( 'current_user_has_wpcom_account' ) && ! current_user_has_wpcom_account() ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Addison-Stavlo Is this working? In my testing, I always see the banner even though I am logged in with a local Atomic user.
It seems, it can't find current_user_has_wpcom_account()
function since it's defined in the mu-wpcom plugin, and maybe loaded later...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird! This worked in testing the original PR, but maybe the load order is different in production or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im seeing the banner in my testing now as well...
Fixes # https://github.com/Automattic/dotcom-forge/issues/7892
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
In addition: