Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the WordPress Events and News Dashboard widget #38242

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

lupus2k
Copy link
Contributor

@lupus2k lupus2k commented Jul 8, 2024

Fixes https://github.com/Automattic/dotcom-forge/issues/8060

Proposed changes:

Remove WordPress Events and News feed in the Dashboard widget as it's not relevant to WordPress.com users for Simple Siters.

- Before After
Atomic image image
Simple image image

Jetpack product discussion

Details here: pfsHM7-1fZ-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Follow the instructions in the first comment
  • Check if the WordPress Events and News feed widget shows in Atomic & Simple sites
@lupus2k lupus2k self-assigned this Jul 8, 2024
@lupus2k lupus2k changed the title Remove/wpcom events and news widget on mu Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the remove/wpcom-events-and-news-widget-on-mu branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin remove/wpcom-events-and-news-widget-on-mu
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2
@github-actions github-actions bot added the [Package] Jetpack mu wpcom WordPress.com Features label Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Mu Wpcom plugin:

  • Next scheduled release: August 6, 2024.
  • Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Wpcomsh plugin:

  • Next scheduled release: August 6, 2024.
  • Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jul 8, 2024
@lupus2k lupus2k requested review from a team July 8, 2024 15:38
@lupus2k lupus2k force-pushed the remove/wpcom-events-and-news-widget-on-mu branch from 9ebdd27 to b5bc1c9 Compare July 8, 2024 18:41
@github-actions github-actions bot added [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Wpcomsh labels Jul 9, 2024
@@ -69,6 +69,10 @@ public static function init() {
// Load the Newsletter category settings.
add_action( 'enqueue_block_assets', array( __CLASS__, 'load_newsletter_categories_settings' ), 999 );

// Remove WordPress Events and News feed widget from the dashboard.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "trend" now is to write new mu-wpcom features in a separate feature file, so that features are split logically into individual files. I can help refactor it to a wpcom-admin-dashboard feature today 👍

@fushar fushar force-pushed the remove/wpcom-events-and-news-widget-on-mu branch from 8984173 to a9a12ac Compare July 9, 2024 02:27
@fushar fushar force-pushed the remove/wpcom-events-and-news-widget-on-mu branch from a9a12ac to e0b43e0 Compare July 9, 2024 02:28
@fushar fushar merged commit 53d475b into trunk Jul 9, 2024
54 of 55 checks passed
@fushar fushar deleted the remove/wpcom-events-and-news-widget-on-mu branch July 9, 2024 02:38
@github-actions github-actions bot removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review labels Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment