-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classic Theme Helper: Copy Social Menu code to Classic Theme Helper package #38243
Classic Theme Helper: Copy Social Menu code to Classic Theme Helper package #38243
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
…lassic-theme-helper-package
/* | ||
* Add Mastodon instances to this array. | ||
*/ | ||
$mastodon_instance_list = jetpack_mastodon_get_instance_list(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function seems to be coming from jetpack plugin global functions.
And is what phan is marking as PhanUndeclaredFunction.
I don't think this will be accessible if the package is used in a different plugin than jetpack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I noticed that too - I could presumably copy the function over if needed, I haven't looked into it much though just yet. I won't be dealing with Phan issues until the next PR (I made some minor fixes here, added that suppression, but can't test properly until I'm requiring the code from the package).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is just moving code to the Classic Theme Helper Package changes look good.
Fixes https://github.com/Automattic/vulcan/issues/393
Proposed changes:
Other information:
Jetpack product discussion
https://github.com/Automattic/vulcan/issues/393
Does this pull request change what data or activity we track or use?
No.
Testing instructions: