Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beta: Fix undefined variable reference #38247

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jul 8, 2024

Proposed changes:

$plugin wasn't defined when show-needed-updates.template.php was used from plugin-select.template.php. Define it as null.

Also remove an unnecessary isset(), by that point it is defined.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Visit the plugin select page. Check for warnings.
`$plugin` wasn't defined when `show-needed-updates.template.php` was
used from `plugin-select.template.php`. Define it as null.

Also remove an unnecessary `isset()`, by that point it is defined.
@anomiex anomiex added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Low labels Jul 8, 2024
@anomiex anomiex requested a review from a team July 8, 2024 20:25
@anomiex anomiex self-assigned this Jul 8, 2024
@anomiex anomiex enabled auto-merge (squash) July 8, 2024 20:25
@github-actions github-actions bot added the [Plugin] Beta For serving live branches and the beta versions. https://github.com/automattic/jetpack-beta label Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Beta plugin:

  • Next scheduled release: August 6, 2024.
  • Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@anomiex anomiex merged commit b3e9437 into trunk Jul 9, 2024
55 checks passed
@anomiex anomiex deleted the fix/beta-undefined-variable-ref branch July 9, 2024 11:58
@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Beta For serving live branches and the beta versions. https://github.com/automattic/jetpack-beta [Pri] Low [Type] Bug When a feature is broken and / or not performing as intended
2 participants