-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port wpcom-documentation-links from ETK #38249
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
7fc6306
to
9b2b56b
Compare
03abd0c
to
685412f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works as expected!
Related to https://github.com/Automattic/dotcom-forge/issues/8037.
Proposed changes:
Port the wpcom-documentation-links feature from ETK, which replaces several wordpress.org links to their wordpress.com counterpart, if any.
Note
I did not port the use of localeUrl() since it was more complicated than I thought. As a result, the link URL will always link to the English version. This seems like an acceptible compromise since the support page already has links to other languages in it header.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: