Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack Blocks: Migrate the EventCountdown block from ETK #38250

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Jetpack Blocks: Migrate the EventCountdown block from ETK #38250

merged 4 commits into from
Jul 10, 2024

Conversation

arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Jul 9, 2024 •
edited
Loading

Related to https://github.com/Automattic/dotcom-forge/issues/8032, https://github.com/Automattic/dotcom-forge/issues/8036

Proposed changes:

  • Migrate the EventCoutdown block to Jetpack Blocks
Edit Preview
image image

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Apply changes to your site
  • Go to the editor
  • Insert an Event Countdown block
  • Fill in both title & date
  • Make sure the preview looks as before
  • Preview your changes on frontend
  • Make sure the Event Countdown block looks as before and the countdown works as expected
  • Make sure the celebration shows when countdown finishes
@arthur791004 arthur791004 self-assigned this Jul 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the feat/jetpack-event-countdown-block branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack feat/jetpack-event-countdown-block

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Block] Event Coutdown labels Jul 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for August 6, 2024 (scheduled code freeze on August 5, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.
@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jul 9, 2024
@arthur791004 arthur791004 force-pushed the feat/jetpack-event-countdown-block branch 3 times, most recently from cc619d5 to f91f478 Compare July 9, 2024 06:31
@arthur791004 arthur791004 force-pushed the feat/jetpack-event-countdown-block branch 5 times, most recently from 4715437 to adf7f9f Compare July 9, 2024 09:56
@arthur791004 arthur791004 added [Status] Needs Team Review and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jul 9, 2024
@arthur791004 arthur791004 requested a review from a team July 9, 2024 09:59
@arthur791004 arthur791004 force-pushed the feat/jetpack-event-countdown-block branch from adf7f9f to 5ea33f9 Compare July 9, 2024 10:38
@taipeicoder taipeicoder changed the title Jetpack Blocks: Migrate the EventCoutdown block from ETK Jul 10, 2024
@taipeicoder
Copy link
Contributor

I'm not seeing the styles being loaded on the front-end :-/
Screenshot 2024-07-10 at 10 57 41 AM
@arthur791004
Copy link
Contributor Author

hmmm...it's weird. It looks good on my site 🤔

image
taipeicoder
taipeicoder previously approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Screenshot 2024-07-10 at 12 32 20 PM

[nit] Could we fix the 0 DAYS css? It looks that it has a different font weight.
@arthur791004 arthur791004 merged commit f868d56 into trunk Jul 10, 2024
56 checks passed
@arthur791004 arthur791004 deleted the feat/jetpack-event-countdown-block branch July 10, 2024 05:27
@github-actions github-actions bot added this to the jetpack/13.7 milestone Jul 10, 2024
jeherve
jeherve reviewed Jul 11, 2024
View reviewed changes
projects/plugins/jetpack/extensions/blocks/event-countdown/edit.js
import { dateI18n, __experimentalGetSettings } from '@wordpress/date';
import { __ } from '@wordpress/i18n';
import clsx from 'clsx';
import moment from 'moment';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this works, given that we do not import moment in the Jetpack plugin today:

jetpack/projects/plugins/jetpack/package.json

Line 46 in a0f4db2

"dependencies": {

Maybe that's because Gutenberg calls in moment?

Maybe that's something we should update (maybe we could move away from moment and rely on the core utilities instead?
@jeherve jeherve added the [Status] Needs Testing We need to add this change to the testing call for this month's release label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Event Countdown [Block] Event Coutdown [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Testing We need to add this change to the testing call for this month's release
3 participants
@arthur791004 @taipeicoder @jeherve