Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid showing help center for woocommerce admin homepage #38253

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

heavyweight
Copy link
Contributor

We should hide the help center for the WooCommerce admin home page.
There is already an implementation similar to the help center in this case. This leads to two help center icons being shown, which might confuse the user.

WooCommerce Documentation Help Center
Screenshot 2024-07-09 at 11 57 26 Screenshot 2024-07-09 at 11 57 10
Before After
Screenshot 2024-07-09 at 11 55 51 Screenshot 2024-07-09 at 11 54 47

Fixes #
8125-gh-Automattic/dotcom-forge

Proposed changes:

  • Avoid enqueuing the help center for this page

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Test this PR with site for which you have the Entrepreneur plan. Sync jetpack-mu-wpcom to it
  • Navigate to https://{your-site}/wp-admin/admin.php?page=wc-admin
  • Ensure that the help center is not shown there
  • Ensure that the help center is shown for the other pages as before
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/hide-hc-wc-admin branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/hide-hc-wc-admin
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2
@github-actions github-actions bot added the [Package] Jetpack mu wpcom WordPress.com Features label Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jul 9, 2024
/**
* Returns true if the current screen is the woo commerce admin home page.
*/
public function is_wc_admin_home_page() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this can be private.

alshakero
alshakero previously approved these changes Jul 9, 2024
Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heavyweight heavyweight merged commit bfa2cbf into trunk Jul 9, 2024
54 checks passed
@heavyweight heavyweight deleted the fix/hide-hc-wc-admin branch July 9, 2024 11:24
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants