-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Blocks: Migrate the Timeline block from ETK #38255
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
ce9edae
to
93f4056
Compare
93f4056
to
15f09a2
Compare
I may not be up to date 🙏, but could you explain why this uses the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The block worked as expected for me 👍
These blocks are designed for Jetpack but they were implemented in ETK plugin first. So, I think it makes sense to migrate them to Jetpack. See Automattic/wp-calypso#37889 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely 👍
Hello, the release notes for 13.7 say that the Event Countdown and Timeline blocks were added: https://wordpress.org/plugins/jetpack/#developers However, I don't see these blocks on my websites running Jetpack 13.7. I confirmed that I have "Jetpack Blocks" turned on under "Jetpack Settings > Writing > Composing" This is a problem on multiple websites across multiple hosts, including locally with WordPress.com Studio. |
Referring to https://github.com/Automattic/dotcom-forge/issues/8036#issuecomment-2222306034, we moved those blocks to jetpack-mu-wpcom so it's only available on atomic sites with the mu-wpcom plugin. |
@arthur791004 I see, so what does a self-hosted Jetpack user need to do to use the new Timeline block? |
As discussion, we don't want to expose blocks in the Jetpack plugin. If the Timeline block is useful for Jetpack users, I think we can consider to include the Timeline block in the new Jetpack Extras plugin in the future cc @jeherve |
@arthur791004 thanks for the clarification, I don't have access to this page: https://github.com/Automattic/dotcom-forge/issues/8036 I guess I'm confused by the WordPress.org changelog for Jetpack 13.7. It says: https://wordpress.org/plugins/jetpack/#developers
But those blocks aren't actually available to be used? They'll be coming later to a new Jetpack Extras plugin? |
It's a mistake we forgot to remove that changelog 🙈 Now it's only for WordPress.com users |
Ohh ok. Thanks for clearing that up. |
Related to https://github.com/Automattic/dotcom-forge/issues/8032, https://github.com/Automattic/dotcom-forge/issues/8036
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Timeline
blockAlternative
setting of theTimeline
blockTimeline Entry
blockTimeline Entry
blockTimeline
block looks good on your frontend page