-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calypsoify: Removing Calypsoify files and references from the Jetpack plugin #38259
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this @coder-karen.
This tests well for me in WoA and self-hosted.
Also a search for the calyspoify
token inside the jetpack plugin now only returns changelogs, buildfiles and some occurrences on the deprecated wpcom-block-editor which will be removed soon too.
Fixes https://github.com/Automattic/vulcan/issues/324
Proposed changes:
Other information:
Jetpack product discussion
https://github.com/Automattic/vulcan/issues/324
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
For WoA sites in particular we want to confirm that Calypsoify continues to work as before.
WoA:
calypsoify=1
param to the URL. Example:https://example.com/wp-admin/post.php?post=827&action=edit&calypsoify=1
.calypsoify_wpadminmods_js-css
andcalypsoify_wpadminmods_js-js-extra
).&calypsoify=1
from the URL, and refresh. Click on the 'options' menu, and you should see the option to toggle off Fullscreen mode. Click this, and refresh the page to confirm the change sticks./wp-admin/revision.php?revision=122&calypsoify=1
). The revision page should now be full-screen (vs. not without Calypsoification).Simple:
admin-plugins/calypsoify.php
.Self-hosted:
jetpack build plugins/jetpack
, choosing the option to build all dependencies. If using the Beta Tester plugin, the branch only needs to be applied for the Jetpack plugin.