Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP Super Cache: fix clearing the cache when scheduled posts are published #38263

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

donnchawp
Copy link
Contributor

A recent change added an "is backend" check to the code very early on in the "boot up" process of the request. One "is backend" URL is the website CRON function. This stopped the plugin hooking various functions that did maintenance of the cache. One of those was the transition action that fires when a post goes from scheduled to publish.
That stopped scheduled posts from clearing the cache as the caching system was disabled when CRON jobs ran.

Fixes #38257

Proposed changes:

  • Remove the is_backend check from wp_cache_postload()

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1720508923710769-slack-C016BBAFHHS

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • This is possibly easier to debug if you disable the WP cron and call it from the system cron as it's more predictable, especially on a quiet website.
  • Enable the debug log.
  • Schedule a post for 2 minutes into the future.
  • Keep an eye on the debug log.
  • When the post is "published", the debug log will show something like this when the post is published: wp_cache_post_edit: Clearing cache for post X on clean_post_cache
  • Reload the posts page and the new post should be there.
@donnchawp donnchawp added [Status] Needs Team Review [Plugin] Super Cache A fast caching plugin for WordPress. labels Jul 9, 2024
@donnchawp donnchawp self-assigned this Jul 9, 2024
@donnchawp donnchawp requested a review from a team July 9, 2024 15:53
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Super Cache plugin:

  • Next scheduled release: August 6, 2024.
  • Scheduled code freeze: July 29, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Member

@dilirity dilirity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@donnchawp donnchawp merged commit 985d200 into trunk Jul 10, 2024
55 checks passed
@donnchawp donnchawp deleted the super-cache/fix/scheduled-posts branch July 10, 2024 10:56
@github-actions github-actions bot added this to the super-cache/1.12.2 milestone Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Super Cache A fast caching plugin for WordPress.
2 participants