Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update pnpm message in check-lock-files.sh #38264

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jul 9, 2024

Proposed changes:

It doesn't matter which directory you run pnpm install in. That's left over from when we still used yarn without workspaces.

OTOH, there are some cases where pnpm install doesn't make a change but pnpm install --resolution-only does. Suggest the latter in case the former fails to make the needed change.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

#38146 (comment)

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • CI happy?
  • You might try making a change based on this one where you update a package.json dep version without running pnpm install.
It doesn't matter which directory you run `pnpm install` in. That's left
over from when we still used `yarn` without workspaces.

OTOH, there are some cases where `pnpm install` doesn't make a change
but `pnpm install --resolution-only` does. Suggest the latter in case
the former fails to make the needed change.
@anomiex anomiex added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Jul 9, 2024
@anomiex anomiex requested a review from a team July 9, 2024 18:27
@anomiex anomiex self-assigned this Jul 9, 2024
@anomiex anomiex enabled auto-merge (squash) July 9, 2024 18:27
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@anomiex anomiex merged commit f0c86f2 into trunk Jul 11, 2024
55 of 56 checks passed
@anomiex anomiex deleted the update/check-lock-files-pnpm-message branch July 11, 2024 19:12
@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management [Pri] Normal [Type] Janitorial
2 participants